You have the right idea: the geometry intersects between the vertical segments of the cylinder. If you're happy with how it subdivides and it bakes down fine then it's passable. It all depends on how clean it needs to be and what you're using it for. Where you can run in to problems: the two vertical loops on either side…